refactor: add note to deliver note#10482
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/remove-get-outgoing-notes-from-interface
branch
from
02e0cf0 to
e7dbfc8
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/rename-add-note-to-deliver-note
branch
from
5168e57 to
390329a
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/remove-get-outgoing-notes-from-interface
branch
from
e7dbfc8 to
a0cd02c
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/rename-add-note-to-deliver-note
branch
from
390329a to
38e8ae9
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/remove-get-outgoing-notes-from-interface
branch
from
a0cd02c to
98973ff
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/rename-add-note-to-deliver-note
branch
from
38e8ae9 to
9277991
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/rename-add-note-to-deliver-note
branch
from
9277991 to
9cfd934
Compare
|
I actually prefer |
I think during the discussion we preferred "deliver" over "add" because the note is not necessarily added, as the note hash must already exist for this to work. So in essence you may use this to "deliver" an already "added" / "created" note (that may not have been emitted) to yourself. Maybe we can think of a better name ? |
|
Closing as |
sklppy88
deleted the
ek/refactor/pxe-cleanup/rename-add-note-to-deliver-note
branch
2 participants
In this PR, we are renaming
pxe.addNotetopxe.deliverNote. The rationale was because in this function, we aren't actually 'adding a note' to state, as this can only be used when a note (hash) already exists. This is used to deliver the existing note (most likely to self), and (most likely) when said note was not emitted.